[WIP] fix: resolve and unwrap AsyncHasMany for store.createRecord()
#9402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runspired
reviewed
May 13, 2024
| // For `AsyncHasMany`: apply `Awaited` and check if the type is a `RelatedCollection`. If so, | ||
| // unwrap it and convert it to a plain array of the model type. For everything else (including | ||
| // `AsyncBelongsTo`): apply `Awaited`. | ||
| [K in keyof T]: NonNullable<Awaited<T[K]>> extends RelatedCollection<infer M> ? Array<M> : Awaited<T[K]>; |
There was a problem hiding this comment.
it should work here to check if it extends Array<infer M>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP. The code works as expected but a cyclical dependency was introduced that needs to be resolved.
Description
In #9396 the prop types expected by
store.createRecord()were updated to resolveAsyncBelongsToto the underlying model.AsyncHasManywasn't handled though, so this PR addresses that. To do so theCreateRecordPropertiestype util was updated to look forRelatedCollections (which are the result ofAwaited-ing theAsyncHasManytype) and then the model used in the collection is turned into a plain array of that model type. This allows the following:Previously this would error because
[existingChildModel]in the model props wasn't of typeRelatedCollection<ChildModel>.Notes for the release
N/A