fix: add better embroider test and fix embroider compat #8410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@runspired maybe we get already with this tests the same error like explained in #8396, otherwise we need to add some other tests, which should fail |
runspired
force-pushed
the
add-embroider-try-scenarios
branch
2 times, most recently
from
7c92f18
to
28ba8db
Compare
runspired
added
🎯 canary
runspired
force-pushed
the
add-embroider-try-scenarios
branch
from
c1422e8
to
0a9d1ae
Compare
|
@mkszepp ended up adding a test which failed because we can't use @embroider/test-setup currently as it results in downstream build errors: glimmerjs/glimmer.js#406 I think the solution here is to not use moduleExists (since no module does exist) and to use dependencySatisfies. This was failing because (as you noticed but I'm not sure quite communicated well enough in #8403 for me to understand why that was what you were doing) there is no module for moduleExists to find. |
runspired
added
🏷️ bug
runspired
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add embroider try scenarios for tests