[BUGFIX CHORE] fix native-class use by eliminating use of Ember.Error #5753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
previously approved these changes
Nov 20, 2018
|
Failing 2.18 for run-loop issues (easy test fix) and ember beta/canary for unknown reasons. |
runspired
dismissed
rwjblue’s stale review
changes have happened and we need to continue investigating direction
runspired
added
concept-review
|
We resolved this by reverting the change from function to class based definition of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #5752
Unfortunately our Error classes are fully public API (including instantiating them). I've opened up an RFC issue to discuss migrating us away from this pattern. emberjs/rfcs#402