Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] ember intends on making length non-settable #5504

Closed
wants to merge 1 commit into from

Conversation

runspired
Copy link
Contributor

@runspired runspired commented Jun 26, 2018

cc @rwjblue @krisselden

see emberjs/ember.js#16776 for reference

I believe we should backport this all the way to 2.18 LTS

@rwjblue
Copy link
Member

rwjblue commented Jun 27, 2018

These failures seem legit:

354) [Chrome 67.0] unit/record_array - DS.RecordArray: stops updating when destroyed
     Has no more records
     expected: 0
       actual: 1
         at http://localhost:7357/assets/tests.js:9970:14
         at Backburner._run (http://localhost:7357/assets/vendor.js:21220:35)
         at Backburner.run (http://localhost:7357/assets/vendor.js:20930:25)
         at Object.run (http://localhost:7357/assets/vendor.js:37594:29)
         at Object.<anonymous> (http://localhost:7357/assets/tests.js:9969:11)
         at runTest (http://localhost:7357/assets/test-support.js:4199:30)

1404) [Chrome 67.0] unit/record-arrays/record-array - DS.RecordArray: #destroy
     expected: null
       actual: [ [length]: 0 ]
         at Object.<anonymous> (http://localhost:7357/assets/tests.js:45809:12)
         at runTest (http://localhost:7357/assets/test-support.js:4199:30)
         at Test.run (http://localhost:7357/assets/test-support.js:4185:6)
         at http://localhost:7357/assets/test-support.js:4406:12
         at advanceTaskQueue (http://localhost:7357/assets/test-support.js:3798:6)
         at advance (http://localhost:7357/assets/test-support.js:3779:4)
1406) [Chrome 67.0] unit/record-arrays/record-array - DS.RecordArray: #destroy 
     expected: null
       actual: [ [length]: 0 ]
         at Object.<anonymous> (http://localhost:7357/assets/tests.js:45874:12)
         at runTest (http://localhost:7357/assets/test-support.js:4199:30)
         at Test.run (http://localhost:7357/assets/test-support.js:4185:6)
         at http://localhost:7357/assets/test-support.js:4406:12
         at advanceTaskQueue (http://localhost:7357/assets/test-support.js:3798:6)
         at advance (http://localhost:7357/assets/test-support.js:3779:4)

@rwjblue
Copy link
Member

rwjblue commented Jun 27, 2018

emberjs/ember.js#16783 should make this PR not required, but we should likely still land it 😸

@rwjblue
Copy link
Member

rwjblue commented Jun 28, 2018

Fixed on the Ember side.

@rwjblue rwjblue closed this Jun 28, 2018
@runspired runspired deleted the fix-array-emptying branch October 17, 2018 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants