Serialize empty hasMany relationships #5466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests on canary are failing due to the issue reported here: #5465 |
|
Nice! I'll pull that into my branch as soon as it's merged. |
ryanto
force-pushed
the
serialize_empty_has_many
branch
from
349afe2
to
bff2093
Compare
runspired
approved these changes
May 8, 2018
ryanto
added a commit
to ryanto/data
that referenced
this pull request
Jul 27, 2018
ryanto
added a commit
to ryanto/data
that referenced
this pull request
Jul 27, 2018
This was referenced Jul 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for the issue reported here. We will now serialize an empty list when the relationship has no records.
This PR removes the
if (nonNewHasMany.length > 0) {guard and restructures some of the code.