Tooling team meeting 2023-12-19.md #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lifeart
reviewed
Dec 19, 2023
chancancode
reviewed
Dec 19, 2023
|
|
||
| ### TypeScript team | ||
|
|
||
| - rollup TypeScript team into the tooling team |
chancancode
reviewed
Dec 19, 2023
chancancode
reviewed
Dec 19, 2023
| - TODO: investigate -- does ember-intl use `moduleName`? we know the inspector does | ||
| - ember language server's ember-intl integration? | ||
| - Idea: `<template>` doesn't emit `moduleName` | ||
| - need to communicate that `moduleName` is optional / sometimes missing |
There was a problem hiding this comment.
This is already the case – precompile has moudleName marked as optional, technically, moduleName on the template is always present, but only because we default it to this string https://github.com/glimmerjs/glimmer-vm/blob/cb867e388d0de3547b3f4ebc10e2e92c95b75d7e/packages/%40glimmer/compiler/lib/compiler.ts#L128
So it would be non-breaking, at least technically speaking, to always set it to that string, and consumers should already be accounting for that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.