Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .gitattributes file to better simulate a Windows environment #164

Merged
merged 1 commit into from
Nov 3, 2019

Conversation

kellyselden
Copy link
Member

@kellyselden kellyselden commented Nov 2, 2019

Attempting to reproduce ember-codemods/ember-angle-brackets-codemod#160 on Windows CI.

@kellyselden
Copy link
Member Author

Judging by #163, I think the Windows image has regressed somehow.

Copy link
Member

rwjblue commented Nov 3, 2019

Ya, I think that GitHub added yarn to the system image. They don’t really give a very good insight into the environment changes :/

@kellyselden kellyselden changed the title add .gitattributes file to better simulate a Windows environment WIP add .gitattributes file to better simulate a Windows environment Nov 3, 2019
@rwjblue
Copy link
Member

rwjblue commented Nov 3, 2019

Thanks for fixing CI! Looks like this is passing now.

Can you explain how this better simulates a windows environment though? The tests I added in #141 are not platform dependent (they use various combos of \n and \r\n confirming the endings are preserved).

@rwjblue rwjblue changed the title WIP add .gitattributes file to better simulate a Windows environment Add .gitattributes file to better simulate a Windows environment Nov 3, 2019
@rwjblue rwjblue merged commit 684b7b4 into ember-template-lint:master Nov 3, 2019
@rwjblue
Copy link
Member

rwjblue commented Nov 3, 2019

Either way this seems good (and passes), so I'm going to merge...

@kellyselden
Copy link
Member Author

Can you explain how this better simulates a windows environment though?

The only OS specific difference I can think of between this test suite and ember-cli-update's test suite is this file. I remember fiddling with different settings, and this file was the key to get Windows to preserve it's line endings and git to not force everything into \n. It's all kinda black magic though in the end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants