Reexport builders from @glimmer/syntax
#123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
approved these changes
Oct 1, 2019
|
yeah, I had cleared the CI caches and restarted but now there is an actual test failing. not sure what's going on. |
|
The floating deps failure is caused by handlebars-lang/handlebars.js#1562. |
|
I'm going to pin handlebars to 4.1.2 for now while that issue is dealt with. |
We already have `builders` as part of our public API because we pass it to the plugin in the `transform()` function. Only having access to the builders within that plugin makes the implementation a bit cumbersome though. I don't see a reason why we shouldn't just reexport it directly too, so that implementing helper functions becomes easier.
|
Landed CI fixes in #127 and rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have
buildersas part of our public API because we pass it to the plugin in thetransform()function. Only having access to the builders within that plugin makes the implementation a bit cumbersome though. I don't see a reason why we shouldn't just reexport it directly too, so that implementing helper functions becomes easier.