Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update yargs to 17.5.1 to fix --version #2509

Merged

Conversation

jamescdavis
Copy link
Contributor

@jamescdavis jamescdavis commented May 16, 2022

fixes #2431

There was an issue with yargs when used with ESM that caused --version to report the consuming app's version instead of ember-template-lint's. This was fixed in yargs/yargs#2123 and released in yargs@17.5.1.

@bmish bmish added the bug label May 16, 2022
@bmish bmish changed the title require yargs@^17.5.1 to fix --version Update yargs to 17.5.1 to fix --version May 16, 2022
Copy link
Member

@bmish bmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bmish bmish merged commit e2893c4 into ember-template-lint:master May 16, 2022
@jamescdavis jamescdavis deleted the bump_yargs_to_fix_version branch May 17, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Executable flag '--version' does not echo correct version
2 participants