Fix --version #2501
Closed
Fix --version #2501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmish
reviewed
May 9, 2022
| @@ -130,7 +132,7 @@ export function parseArgv(_argv) { | |||
| .usage('$0 [options] [files..]') | |||
| .options(specifiedOptions) | |||
| .help() | |||
| .version(); | |||
| .version(require('../../package.json').version); | |||
There was a problem hiding this comment.
This seems to indicate there is a yargs bug in retrieving the version, perhaps when ESM is present? Is there an active yargs issue for this? I'd prefer it was fixed there. If we are going to add a workaround, we would at least need to comment to explain why it's needed.
There was a problem hiding this comment.
You're suspicion is correct!: yargs/yargs#2122
There was a problem hiding this comment.
I've verified yargs/yargs#2123 fixes the issue, so hopefully that will go in soon!
|
This is bug in yargs: yargs/yargs#2122 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2431