Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: Disallow duplicate test cases #2279

Merged
merged 1 commit into from Dec 16, 2021

Conversation

bmish
Copy link
Member

@bmish bmish commented Dec 15, 2021

This updates the test runner to fail when it detects duplicate test cases.

Example output:

 FAIL  test/unit/rules/no-duplicate-id-test.js
  ● no-duplicate-id › <div id={{"id-00"}}></div><div id={{"id-01"}}></div>: passes

    assert(received)

    Expected value to be equal to:
      true
    Received:
      false
    
    Message:
      detected duplicate `good` test case

Part of v4 release (#1908).

TODO:

@bmish bmish added the breaking label Dec 15, 2021
@bmish bmish mentioned this pull request Dec 15, 2021
58 tasks
@bmish bmish changed the title Disallow identical test cases Disallow duplicate test cases Dec 15, 2021
@bmish bmish force-pushed the no-identical-tests branch 2 times, most recently from 7c7ccae to ea82a07 Compare December 15, 2021 20:28
@bmish bmish added this to the 4.0.0 milestone Dec 15, 2021
@bmish bmish requested a review from dcyriller December 15, 2021 21:13
@bmish bmish merged commit 1ac1d1f into ember-template-lint:next Dec 16, 2021
@bmish bmish deleted the no-identical-tests branch December 16, 2021 01:28
@bmish bmish changed the title Disallow duplicate test cases Testing: Disallow duplicate test cases Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant