-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(todos): Adds support for configuring todo decay days by rule #1993
Conversation
@scalvert confirmed that it throws the conflicting configuration file error if lint todo configurations exist in both |
@MelSumner thanks for checking that. That's not a very nice user experience. We can do better by adding a util in todo-utils that checks for this case, and allows consumers to validate early, and fail with a nicer formatted message. WDYT? |
lint-todo/utils#242 lets us fix that issue (still needs tweaks here once its released to actually do it though). |
@MelSumner @rwjblue I updated the code to support validating the todo config beforehand, so it's cleaner output. |
@rwjblue any feedback on this one? It'd be nice to get it merged sooner rather than later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking forward to this feature! 👍
Implements #1880 and supersedes #1964.
This change adds support for using a config file,
.lint-todorc.js
. This config is a superset of the old config, which was simply:The new structure adds a level of nesting, allowing you to specify which
engine
the config section applies to:In addition, you can now configure
daysToDecay
by ruleID, allowing more fine-grained configuration of decay dates. It also provides a single source of truth for configuring those dates.As of this change, we now support
package.json
.lint-todorc.js