Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading yeoman-environment to 3.4.1 #1962

Merged
merged 4 commits into from
Jun 14, 2021
Merged

Conversation

scalvert
Copy link
Member

Resolves console.warn in tests related to mismatched dependency versions between yeoman-generator and yeoman-environment.

@scalvert scalvert requested review from bmish and rwjblue May 24, 2021 15:54
@rwjblue
Copy link
Member

rwjblue commented May 24, 2021

Fails on Node 10:

FAIL test/unit/generator-test.js
  ● generators › generates the rules index file correctly

    TypeError: Object.entries(...).map(...).flat(...) is not a function or its return value is not iterable

      at Environment.getAllGenerators (node_modules/yeoman-environment/lib/environment.js:851:10)
      at Environment.getGeneratorsFeatures (node_modules/yeoman-environment/lib/generator-features.js:11:51)
      at Environment.getGeneratorsFeature (node_modules/yeoman-environment/lib/generator-features.js:24:12)
      at Environment.getGeneratorUniqueFunctionFeature (node_modules/yeoman-environment/lib/generator-features.js:38:48)
      at Environment.findGeneratorCustomCommitTask (node_modules/yeoman-environment/lib/generator-features.js:65:17)
      at runLoop.add (node_modules/yeoman-environment/lib/environment.js:1243:37)
      at Immediate.setImmediate (node_modules/grouped-queue/lib/subqueue.js:48:34)

@scalvert
Copy link
Member Author

I think you previously mentioned guarding these tests. Thoughts on this?

@rwjblue
Copy link
Member

rwjblue commented May 24, 2021

Ya, seems fine to me

@scalvert
Copy link
Member Author

OK, done. CI is just running.

@scalvert
Copy link
Member Author

@rwjblue I think this is GTG.

@rwjblue rwjblue merged commit 0acfbea into master Jun 14, 2021
@rwjblue rwjblue deleted the upgrade-yeoman-environment branch June 14, 2021 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants