Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes --clean-todo flag to actually do the cleaning #1945

Merged
merged 1 commit into from
May 10, 2021
Merged

Conversation

scalvert
Copy link
Member

The --clean-todo flag was missing from the todo-handler, resulting in this flag effectively being a noop. This fix ensures that both --clean-todo and --fix work for cleaning todos, though we prefer users run the narrowly scoped --clean-todo, as it changes less and results in more predictable effects.

@scalvert scalvert added the bug label May 10, 2021
Copy link
Contributor

@MelSumner MelSumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that this works to resolve the issue (pulled the branch down, used yarn link, and went through the workflow).

@scalvert scalvert merged commit c4cf510 into master May 10, 2021
@scalvert scalvert deleted the fix-clean-todo branch May 10, 2021 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants