Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the A11Y preset #1874

Merged
merged 1 commit into from
Jun 10, 2021
Merged

Document the A11Y preset #1874

merged 1 commit into from
Jun 10, 2021

Conversation

bertdeblock
Copy link
Collaborator

Description taken from this comment.

Closes #1677.

MelSumner
MelSumner reviewed Apr 14, 2021
View reviewed changes
Copy link
Contributor

@MelSumner MelSumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this also include the 👍 in the rule table, to show which rules are in the a11y preset?

@bertdeblock
Copy link
Collaborator Author

Totally forgot about that, but that makes sense yes. Btw I only choose the 👍 emoji because I didn't know what else would fit.

@bertdeblock
Copy link
Collaborator Author

@MelSumner Updated accordingly.

@scalvert
Copy link
Member

scalvert commented May 7, 2021

Does 👍 make sense as the emoji here? It doesn't really say Accessibility to me (I don't know what the alternative would be).

@MelSumner MelSumner requested review from MelSumner and bmish May 10, 2021 18:59
@bmish
Copy link
Member

bmish commented May 10, 2021 •
edited

I don't think 👍 is a good emoji for this preset. Perhaps ♿?

@bertdeblock
Copy link
Collaborator Author

Agreed that thumbs up isn't very representative. Let me know what it should be and I'll update!

@bertdeblock
Copy link
Collaborator Author

Rebased and updated the emoji to be ♿.

MelSumner
MelSumner approved these changes May 24, 2021
View reviewed changes
Copy link
Contributor

@MelSumner MelSumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (non-blocking) I don't think that there is a good icon for this right now. We should ship it as-is, and change it as soon as we figure out what to use instead.

Thank you for doing this work! 👍

@rwjblue
Copy link
Member

rwjblue commented Jun 10, 2021

@bertdeblock - Sorry for the run around here, let's use :keyboard: ⌨️ instead.

rwjblue
rwjblue approved these changes Jun 10, 2021
View reviewed changes
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rwjblue rwjblue merged commit b2589db into ember-template-lint:master Jun 10, 2021
@bertdeblock bertdeblock deleted the document-a11y-preset branch September 1, 2021 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

@MelSumner MelSumner MelSumner approved these changes

@bmish bmish Awaiting requested review from bmish

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why is a11y preset is not listed in README
5 participants
@bertdeblock @scalvert @bmish @rwjblue @MelSumner