Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow ember-template-lint v5 #237

Merged
merged 1 commit into from Nov 4, 2022
Merged

Allow ember-template-lint v5 #237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 19 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Expand Up @@ -53,6 +53,25 @@ jobs:

- run: yarn test

ember-template-lint:
name: ember-template-lint@${{ matrix.etlVersion }}
needs: [test]
runs-on: ubuntu-latest
timeout-minutes: 10

strategy:
matrix:
etlVersion: [^4.0.0, 5.0.0-alpha.0]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will update to etlVersion: [^4.0.0, ^5.0.0], once there is a stable release.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#245


steps:
- uses: actions/checkout@v2
- uses: volta-cli/action@v1
Comment on lines +67 to +68
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- uses: actions/checkout@v2
- uses: volta-cli/action@v1
- uses: actions/checkout@v3
- uses: volta-cli/action@v4

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just uses the same versions as the other jobs, I could make a separate PR to bump everything and then rebase this one?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made #238.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, separate PR is fine.

with:
node-version: 16.x
- run: yarn install --frozen-lockfile
- run: yarn add ember-template-lint@${{ matrix.etlVersion }} --dev
- run: yarn test

floating-dependencies:
name: Floating Dependencies
runs-on: ubuntu-latest
Expand Down
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Expand Up @@ -33,7 +33,7 @@
"prettier-linter-helpers": "^1.0.0"
},
"devDependencies": {
"ember-template-lint": "^4.0.0-beta.3",
"ember-template-lint": "^4.0.0",
"eslint": "^8.2.0",
"eslint-config-prettier": "^8.3.0",
"eslint-plugin-node": "^11.0.0",
Expand All @@ -47,8 +47,8 @@
"release-it-lerna-changelog": "^4.0.1"
},
"peerDependencies": {
"ember-template-lint": "^4.0.0",
"prettier": ">=1.18.1"
"ember-template-lint": ">= 4.0.0",
"prettier": ">= 1.18.1"
},
"engines": {
"node": "^12.22.0 || ^14.17.0 || >=16.0.0"
Expand Down