Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ember-cli to 3.14 #489

Merged
merged 1 commit into from Dec 18, 2019
Merged

update ember-cli to 3.14 #489

merged 1 commit into from Dec 18, 2019

Conversation

hjdivad
Copy link
Collaborator

@hjdivad hjdivad commented Dec 17, 2019

  • drop jQuery use in tests (keep it for now for tests in 3.8)
  • now we target chrome for tests; class code is readable again

@hjdivad hjdivad force-pushed the hjdivad/upgrade-ember-cli branch 2 times, most recently from 939ddea to 536ef2e Compare December 17, 2019 02:42
@hjdivad hjdivad requested a review from rwjblue December 17, 2019 02:52
- now we target chrome for tests; class code is readable again
@hjdivad
Copy link
Collaborator Author

hjdivad commented Dec 18, 2019

We can ignore the babel-plugin-debug-macros warnings, they're spurious from ember-resolver and fixed in ember-cli/ember-resolver#475

@hjdivad
Copy link
Collaborator Author

hjdivad commented Dec 18, 2019

warnings are also more actionable now ember-cli/babel-plugin-debug-macros#81

@hjdivad hjdivad merged commit ce69586 into master Dec 18, 2019
@hjdivad hjdivad deleted the hjdivad/upgrade-ember-cli branch December 18, 2019 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant