-
-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace inline styles with docs-container class #463
base: master
Are you sure you want to change the base?
Conversation
Our own demo app uses a class instead of inline styles, but the guides never got updated. This will fail linting in most apps, and since we already provide the class for it, we should just tell users to use it.
@elwayman02 I think there was some issue posted awhile ago and this was changed to be inline for some reason. @samselikoff do you recall? |
Yeah the |
Hmm, then perhaps we should have some sort of docs-container component instead? The problem atm is that the default linting rules include |
All that said, if this project is in fact going into maintenance mode, it seems unlikely that the |
We should definitely add a |
Didn't realize Really meant to add a Styling guide to explain that AD components are styled but the rest of the styles in the app are up to you to do it in userland however you like. |
Yea, it look like that rule was added to the default ruleset when Rob was prepping for the 1.0.0 release of ember-template-lint: ember-template-lint/ember-template-lint#457 |
@elwayman02 mind rebasing this with master please? |
Our own demo app uses a class instead of inline styles, but the guides never got updated. This will fail linting in most apps, and since we already provide the class for it, we should just tell users to use it.