Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation of Ember array prototype extensions to issue 204 #1215

Conversation

bmish
Copy link
Contributor

@bmish bmish commented Oct 11, 2022

Ember Times review template

  • Add your name to top and bottom
  • Put emoji in writeup title
  • Add a short blurb (could be the title) to the beginning
  • Link to external article/repo/etc in paragraph/body text, not just the writeup title (link in writeup title is optional now)
  • Add the contributor in the post in format "FirstName LastName (@githubusername)" linked to their GitHub account
  • Check that all links work

What it does

Add a section covering:

  • RFC merged for deprecation of Ember array prototype extensions
  • Ember array prototype extensions disabled by default in ember-cli blueprint
  • Lint rule autofixer implemented for Ember array prototype extensions

NOTE: This is a draft until:

I'm happy to add additional detail to this section as requested. Others are also welcome to follow-up to my PR to further flesh out this section.

CC: @smilland @chriskrycho @lin-ll @bertdeblock @tgvrssanthosh

Related Issue(s)

Sources

@probot-autolabeler probot-autolabeler bot added the embertimes PR for an Ember Times issue label Oct 11, 2022
@bmish bmish force-pushed the 204-deprecate-array-prototype-extensions branch 3 times, most recently from a9d4fec to a7a1c51 Compare October 18, 2022 02:04
@bmish bmish force-pushed the 204-deprecate-array-prototype-extensions branch from a7a1c51 to d1447fd Compare October 20, 2022 18:38
@bmish bmish marked this pull request as ready for review October 25, 2022 16:07
@bmish bmish requested a review from a team as a code owner October 25, 2022 16:07
@chrisrng chrisrng merged commit ad50fe4 into ember-learn:blog/embertimes-204 Oct 25, 2022
jaredgalanis pushed a commit that referenced this pull request Nov 6, 2022
* docs: add deprecation of Ember array prototype extensions to issue 204

* Update content/the-ember-times-issue-204.md

Co-authored-by: Chris Ng <chrisrng@users.noreply.github.com>

* docs: link to ember-cli v4.9.0-beta.0

Co-authored-by: Chris Ng <chrisrng@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
embertimes PR for an Ember Times issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants