New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove ember string namespace #687

Merged

jaredgalanis merged 2 commits into ember-learn:master from JamesS-M:remove-ember-string-namespace

Oct 16, 2020

Contributor

JamesS-M commented Oct 16, 2020

removing this per discussion with @locks and @jaredgalanis
This will be reintroduced when the underlying work is ready: RFC #0236 - Tracking for Ember.String deprecation emberjs/rfc-tracking#26
Closes Text for Ember.String namespace deprecation is incomplete #686

JamesS-M added 2 commits

October 16, 2020 10:22


          remove ember string namespace

2668eb0

- removing this per discussion with @locks


          remove ember string prototype extensions

0cbe076

jaredgalanis approved these changes

View reviewed changes

Member

jaredgalanis left a comment

Looks great! 🎉 Thank you for your contribution.

jaredgalanis merged commit 160be59 into ember-learn:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment