Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema version 6: lookup fastboot info #823

Closed
wants to merge 1 commit into from
Closed

Conversation

xg-wang
Copy link
Member

@xg-wang xg-wang commented Apr 7, 2021

Implicit injection is deprecated https://deprecations.emberjs.com/v3.x#toc_implicit-injections

Fixes #819
Depends on #822

This is breaking change because user needs to upgrade to compatible fastboot

@xg-wang xg-wang added this to the ember-cli-fastboot v3 milestone Apr 7, 2021
@rwjblue
Copy link
Member

rwjblue commented May 20, 2021

I think we can do this without a breaking change. The deprecation does nto fire when you call instance.inject it gets called when you the FastBoot service is created. So we can always call instance.inject then we can update fastboot service to use a caching getter to grab the value. Using that setup will avoid the deprecation, and avoid requiring us to rev the schema.

@rwjblue
Copy link
Member

rwjblue commented May 20, 2021

@xg-wang
Copy link
Member Author

xg-wang commented May 20, 2021

@rwjblue oh that's nice, thanks for the examples. I'll update the PR

@rwjblue rwjblue marked this pull request as draft May 24, 2021 15:57
@rwjblue
Copy link
Member

rwjblue commented May 24, 2021

Moved to draft for now (lemme know when ready for another round of review)

@xg-wang
Copy link
Member Author

xg-wang commented Aug 8, 2021

Closed by #841

@xg-wang xg-wang closed this Aug 8, 2021
@xg-wang xg-wang deleted the fastbootinfo branch August 8, 2021 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DEPRECATION: A value was injected implicitly on the '_fastbootInfo' property
2 participants