Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for custom FastBoot implementation #751

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Ravenstine
Copy link

I think it's good that ember-cli-fastboot comes with the FastBoot library out of the box, but it would be nice to override that and use your own implementation of FastBoot.

The case where this would be most useful is when someone would want to use a fork of FastBoot, whether it's their own or someone else's. My motivation for adding this option to ember-cli-fastboot so that I can use my FastBoot fork without having to use a hackey postinstall script to make it happen with a symbolic link.

In short, this allows specifying a custom FastBoot class in your ember-cli-build.js file:

const FastBoot = require('my-fastboot-fork');
const app = new EmberApp({
  fastboot: {
    implementation: FastBoot
  }
});

I'm sure most people may not need this, but it's something I would like and I figured I'd put it out there in case anyone thinks it makes sense.

@kratiahuja
Copy link
Contributor

Could you please define what your usecase is to fork fastboot? Is there something missing that is better built within fastboot?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants