Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ember-cli-preprocess-registry to deps #506

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kellyselden
Copy link
Member

@rwjblue
Copy link
Member

rwjblue commented Aug 16, 2017

Not sure we should actually add the dep here. We need to require ember-cli's own version of this or we are going to cause many issues down the line when we update it in ember-cli.

@kellyselden
Copy link
Member Author

@rwjblue Does ember-cli re-export it that you know of? This was causing failures when I tried to npm link ember-cli.

@kratiahuja
Copy link
Contributor

Isn't ember-cli-preprocess-registry standalone? I thought ember-cli depends on it as well.

@rwjblue
Copy link
Member

rwjblue commented Aug 16, 2017

It does, I've just been working on some breaking changes (for ember-cli-preprocess-registry@4) and dealing with the interactions between the two different versions (one from ember-cli-fastboot and one from ember-cli) will be difficult...

@kellyselden
Copy link
Member Author

@rwjblue We could solve this via a simple reexport in ember-cli right?

@kratiahuja
Copy link
Contributor

I am fine with one source of truth (even if it means ember-cli).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants