New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(utils/decorator): handle desc return value #336
fix(utils/decorator): handle desc return value #336
Conversation
This looks like it needs a regression test. |
The build error seems to be unrelated. Can someone restart the build, please? |
b0a199f
to
7323111
Compare
There's quite some auto-formatting noise, but since there is a |
|
||
(NEEDS_STAGE_1_DECORATORS | ||
? test | ||
: skip)('it warns about deprecated descriptor mutation by reference', function(assert) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which pattern do you prefer?
(NEEDS_STAGE_1_DECORATORS ? test : skip)('it ...', function(assert) { ... });
if (NEEDS_STAGE_1_DECORATORS) {
test('it ...', function(assert) { ... });
}
Great job on this one! |
While writing tests for legacy decorators for rwjblue/sparkles-component#22, I noticed that the return value is ignored and that the descriptor needs to be mutated by reference.
I don't think that this is intentional, since we do the opposite for stage 2 decorators using the same callback function.