Make Compatible with Ember 3.9 #101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You should hold off on merging this, the changes in 3.9 will be reverted and pushed until 3.10 |
|
I would keep the PR open for 3.10 though, the architecture should be the same |
|
Ah, I see. Good to know -- I was trolled by the I'll drop that commit but keep it around for now, since I'd like to do these other dependency upgrades anyway. |
`ember/new-module-imports` seems to warn that `notifyPropertyChange` should be imported from `@ember/object`, but that isn’t actually valid. Related issue: ember-cli/eslint-plugin-ember#388
alexlafroscia
force-pushed
the
upgrade-deps
branch
from
c5c37ca
to
3d0f536
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.