Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some more spread syntax tests #935

Merged
merged 1 commit into from Sep 7, 2020
Merged

Add some more spread syntax tests #935

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion tests/lib/rules/classic-decorator-hooks.js
View file
Open in desktop
Expand Up @@ -19,7 +19,8 @@ ruleTester.run('classic-decorator-hooks', rule, {
`
const Foo = EmberObject.extend({
init() {},
destroy() {}
destroy() {},
...foo
})
`,
`
Expand Down
7 changes: 5 additions & 2 deletions tests/lib/rules/new-module-imports.js
View file
Open in desktop
Expand Up @@ -9,7 +9,9 @@ const RuleTester = require('eslint').RuleTester;
// Tests
// ------------------------------------------------------------------------------

const eslintTester = new RuleTester();
const eslintTester = new RuleTester({
parser: require.resolve('babel-eslint'),
});
eslintTester.run('new-module-imports', rule, {
valid: [
{
Expand Down Expand Up @@ -37,7 +39,8 @@ eslintTester.run('new-module-imports', rule, {
import { bool } from '@ember/object/computed';

export default Controller.extend({
isTrue: bool('')
isTrue: bool(''),
...foo
});
`,
parserOptions: { ecmaVersion: 6, sourceType: 'module' },
Expand Down
4 changes: 3 additions & 1 deletion tests/lib/rules/no-attrs-snapshot.js
View file
Open in desktop
Expand Up @@ -4,6 +4,7 @@ const RuleTester = require('eslint').RuleTester;
const { ERROR_MESSAGE } = rule;
const eslintTester = new RuleTester({
parserOptions: { ecmaVersion: 6, sourceType: 'module' },
parser: require.resolve('babel-eslint'),
});

eslintTester.run('no-attrs-snapshot', rule, {
Expand All @@ -22,7 +23,8 @@ eslintTester.run('no-attrs-snapshot', rule, {
} else {
this.set('updated', false);
}
}
},
...foo
});`,
`
export default Ember.Component({
Expand Down
3 changes: 3 additions & 0 deletions tests/lib/rules/no-unnecessary-service-injection-argument.js
View file
Open in desktop
Expand Up @@ -16,6 +16,7 @@ const ruleTester = new RuleTester({
ecmaVersion: 2015,
sourceType: 'module',
},
parser: require.resolve('babel-eslint'),
});

ruleTester.run('no-unnecessary-service-injection-argument', rule, {
Expand Down Expand Up @@ -99,6 +100,8 @@ ruleTester.run('no-unnecessary-service-injection-argument', rule, {
ecmaFeatures: { legacyDecorators: true },
},
},

'export default Component.extend({ ...foo });',
],
invalid: [
// `Component` examples:
Expand Down
6 changes: 4 additions & 2 deletions tests/lib/rules/use-ember-data-rfc-395-imports.js
View file
Open in desktop
Expand Up @@ -15,14 +15,15 @@ const { ERROR_MESSAGE: message } = rule;
// Tests
//------------------------------------------------------------------------------

const ruleTester = new RuleTester({ parserOptions });
const ruleTester = new RuleTester({ parserOptions, parser: require.resolve('babel-eslint') });
ruleTester.run('use-ember-data-rfc-395-imports', rule, {
valid: [
"import Model from '@ember-data/model';",
`import Model, { attr } from '@ember-data';

export default Model.extend({
name: attr('string')
name: attr('string'),
...foo
});
`,
`import LOL from 'who-knows-but-definitely-not-ember-data';
Expand All @@ -43,6 +44,7 @@ ruleTester.run('use-ember-data-rfc-395-imports', rule, {
code: `import DS from 'ember-data';

export default DS.Model.extend({
...foo
});
`,
output: null,
Expand Down