Add catchEvents option (default false) to no-side-effects rule
#916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mongoose700
reviewed
Aug 15, 2020
| } | ||
|
|
||
| /** | ||
| * Finds: |
There was a problem hiding this comment.
Should this also find this.foo?.bar?
tests/lib/rules/no-side-effects.js
Outdated
| { | ||
| // Imported sendEvent function: | ||
| code: | ||
| 'import { sendEvent } from "@ember/object/events"; computed(function() { sendEvent(); })', |
There was a problem hiding this comment.
Could you import it under a different name, to make sure it's not assuming it's named sendEvent?
mongoose700
approved these changes
Aug 15, 2020
… functions inside computed properties
bmish
changed the title
no-side-effects rule to catch event functions inside computed propertiescatchEvents option (default false) to no-side-effects rule
|
Moved new functionality behind a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by the ember-best-practices/no-side-effect-cp rule.
Catches side-effect-causing function calls like:
CC: @mongoose700