Improve set() detection logic in no-side-effects rule to avoid false positives, catch missed cases, and check imports
#914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmish
changed the title
no-side-effects rule to check all imports and avoid false positiveno-side-effects rule to check all imports and avoid false positives
bmish
changed the title
no-side-effects rule to check all imports and avoid false positivesset() detection logic in no-side-effects rule to avoid false positives, catch missed cases, and check imports
… all imports, catch some missed cases, and avoid false positives
This improves the logic for detecting `set()` and `setProperties()` inside computed properties, since there were a lot of problems with it before.
Fixes some false positives including:
```js
computed(function() { foo1.foo2.set('bar', 123); })
```
```js
computed(function() { set('bar', 123); })
```
Catches additional violations including:
```js
computed(function() { this.foo.set('bar', 123); }) // only `this.set()` detected before
```
```js
computed(function() { set(this.foo, 123); }) // only `set(this, ...)` detected before
```
Also updates the rule to use the actual imported names for the `set` and `setProperties` functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the logic for detecting
set()andsetProperties()inside computed properties, since there were a lot of problems with it before.Fixes some false positives including:
Catches additional violations including:
Also updates the rule to use the actual imported names for the
setandsetPropertiesfunctions.Fixes #351
Fixes #377