Update no-test-import-export rule to allow importing from anything under tests/helpers path (when using relative path)
#911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng under tests/helpers path when using relative path
This was referenced Aug 12, 2020
Merged
mongoose700
approved these changes
Aug 13, 2020
| if (importSource.endsWith('-test') && !isTestHelperImportSource(importSource)) { | ||
| if ( | ||
| importSource.endsWith('-test') && | ||
| !isTestHelperImportSource(resolve(dirname(context.getFilename()), importSource)) |
There was a problem hiding this comment.
Ember makes some of the import paths difficult to resolve, since it does things like drop the /addon or /app. I'm not sure you're able to import things from the dummy app in your tests, but if you can this might not resolve correctly.
There was a problem hiding this comment.
That's true. I'm not sure how we could handle that, but fortunately it should be very unlikely for that to affect us with test helper imports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, in this test case, we can resolve the import source path to find out that it is actually a test helper being imported which is allowed:
Follow-up fix for #889 #895 (comment)
CC: @raido @mongoose700