Add new rule no-invalid-dependent-keys

[TheMBTH]

This rule aims to avoid mismatched open and closed braces.

As discussed in the comments of this issue #105, I added a rule to check that curly braces are balanced within a computed properties' parameters

Fixes #708.

[TheMBTH]

Sorry about the multiple commits & pushes. This is the second time I push and PR on Github 😕 Let me know if I need to change something 😃 .
I also missed something obvious about recommended rules because I created the tests before running generator-eslint.

I struggled a bit to have the CI pass so I will another issue to improve documentation for "newbies" like me 😛

[bmish]

Excited to finally see a rule like this!

[bmish]

@TheMBTH can you remove the unrelated commits?

[TheMBTH]

I rebased and removed the unrelated commits. I rarely rebase so I am not sure about the result.
I wanted to have README updated so I pulled master. How should we keep applying changes from master while we are still working on a PR?
thx 🙏

[bmish]

Almost done!

You should rebase on the latest master frequently, this guide might help: https://github.com/edx/edx-platform/wiki/How-to-Rebase-a-Pull-Request

[bmish]

loc should be removed. Instead, the node that is reported should be string literal node with the violation.

[bmish]

Thanks! (I added commits to fix a few things for you.)

[TheMBTH]

Hi @bmish .... Sorry for the delay. I didn't know there was a release coming and couldn't find the time.
Thanks again for the help. I'll make sure to check your updates.

[TheMBTH]

A few questions regarding your changes:
1 - My tests passed with 'nodeType' because and error needs a type. So the type was actually not checked. It's the message that has a nodeType. Am I correct?
1 - The tests still pass without these options. What was the pupose of adding them?
parserOptions: { ecmaVersion: 6, sourceType: 'module', ecmaFeatures: { legacyDecorators: true }, },

Have a great week-end 😸

Cheers

[bmish]

Thanks for contributing @TheMBTH!

1. Each error object in invalid test cases needs to specify the type of node that is reported as the violation. I changed your rule to report violations on specific string literal nodes and then updated the corresponding tests.
2. If you look at the latest master, I added a test to ensure your rule works with the @computed decorator, which needs additional parserOptions.

[TheMBTH]

Okay thx.
1- understood
2- I saw the test about @computed but when I removed the parserOptions to see check how it works, the tests still passed by passing parser: require.resolve('babel-eslint') only.
I'll look at it on my end to understand.

[bmish]

I see, if any of the new parserOptions are unnecessary, feel free to remove them!