Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add many missing tests for lines without test coverage #611

Merged
merged 2 commits into from
Nov 26, 2019
Merged

Add many missing tests for lines without test coverage #611

merged 2 commits into from
Nov 26, 2019

Conversation

bmish
Copy link
Member

@bmish bmish commented Nov 26, 2019

Used nyc/istanbul to identify lines that were missing test coverage. This addresses many but not all of them.

Improved test coverage will make future refactorings safer to perform.

Before:

--------------------------------------------------------|----------|----------|----------|----------|-------------------|
File                                                    |  % Stmts | % Branch |  % Funcs |  % Lines | Uncovered Line #s |
--------------------------------------------------------|----------|----------|----------|----------|-------------------|
All files                                               |    97.77 |    95.17 |    99.24 |    97.73 |                   |

After:

--------------------------------------------------------|----------|----------|----------|----------|-------------------|
File                                                    |  % Stmts | % Branch |  % Funcs |  % Lines | Uncovered Line #s |
--------------------------------------------------------|----------|----------|----------|----------|-------------------|
All files                                               |    98.37 |    96.45 |    99.43 |    98.34 |                   |

Follow-up to: #505

@bmish bmish added the internal label Nov 26, 2019
@bmish bmish changed the title Add many missing tests for uncovered lines identified by nyc Add many missing tests for uncovered lines identified by istanbul Nov 26, 2019
@bmish bmish changed the title Add many missing tests for uncovered lines identified by istanbul Add many missing tests for lines without test coverage Nov 26, 2019
@bmish bmish merged commit 4701730 into ember-cli:master Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant