Update the no-get rule to also handle the getProperties function, and mark the no-get-properties rule as deprecated
#421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if it's released we can't remove it anymore unfortunately :-/ |
bmish
changed the title
no-get rule to handle getProperties and mark no-get-properties as deprecated
|
@Turbo87 good point, I updated the PR to leave |
|
@pavlikmarek would you like to review since you worked on the related PR? I'll get this released once it's approved. |
|
@Turbo87 will plan to merge this in the next few days unless you have more feedback. |
|
👍 |
…k the `no-get-properties` rule as deprecated
bmish
changed the title
no-get rule to handle getProperties and mark no-get-properties as deprecatedno-get rule to also handle the getProperties function, and mark the no-get-properties rule as deprecated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the discussion in #415 and #419, we decided to make the
no-get-propertiesrule more generic, but then it becomes almost identical to theno-getrule, so then we should just consolidate it into theno-getrule (which can handle boththis.getandthis.getProperties). Both rules are intended to enforce the new ES5 getter syntax, and there's no need to have two separate rules for enforcing the same exact best practice.