Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: improve closure-action rule examples #395

Merged
merged 1 commit into from Mar 14, 2019
Merged

docs: improve closure-action rule examples #395

merged 1 commit into from Mar 14, 2019

Conversation

Caltor
Copy link
Contributor

@Caltor Caltor commented Mar 13, 2019

It wasn't clear before which code snippets related to what. I have split them up with a decent markdown header for each so it is clear what is going on. It took me several read-throughs before to understand these examples.

@bmish bmish self-requested a review March 13, 2019 15:57
Caltor
Caltor commented Mar 13, 2019
View reviewed changes
Copy link
Contributor Author

@Caltor Caltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed as suggested.

bmish
bmish approved these changes Mar 13, 2019
View reviewed changes
Copy link
Member

@bmish bmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bmish
Copy link
Member

bmish commented Mar 13, 2019

Can you squash into one commit?

@Caltor
Copy link
Contributor Author

Caltor commented Mar 13, 2019 •
edited

Can you squash into one commit?

Can I do that through the GitHub web interface?

@bmish
Copy link
Member

bmish commented Mar 13, 2019

I usually do it with:

git rebase --interactive master
<fixup/squash into a single commit>
git push --force

@darrenw-npi
Improved formatting to make examples clearer
3590f88 
It wasn't clear before which code snippets related to what. I have split them up with a decent markdown header for each so it is clear what is going on. It took me several read-throughs before to understand these examples.
@Caltor
Copy link
Contributor Author

Caltor commented Mar 14, 2019

Can you squash into one commit?

Done!

@bmish bmish changed the title Improved formatting to make examples clearer docs: improve closure-action rule examples Mar 14, 2019
@bmish bmish merged commit 88cbd4f into ember-cli:master Mar 14, 2019
@dcyriller dcyriller mentioned this pull request Jul 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmish bmish bmish approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Caltor @bmish @darrenw-npi