Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add null output assertions for lint rules / test cases with no autofixer. #386

Merged
merged 1 commit into from Feb 11, 2019
Merged

test: add null output assertions for lint rules / test cases with no autofixer. #386

merged 1 commit into from Feb 11, 2019

Conversation

bmish
Copy link
Member

@bmish bmish commented Feb 11, 2019

If there's no autofixer for a particular rule or test case, we should assert that there is no output (output refers to the fixed version of the code produced by the autofixer). This helps make our tests more comprehensive, especially so that the tests will catch any future autofixer changes.

The documentation for the output property is here:

output (string, optional): Asserts the output that will be produced when using this rule for a single pass of autofixing (e.g. with the --fix command line flag). If this is null, asserts that none of the reported problems suggest autofixes.

@bmish
test: add null output assertions for lint rules / test cases with no …
25375a9 
…autofixer.

If there's no autofixer for a particular rule or test case, we should assert that there is no output (`output` refers to the fixed version of the code produced by the autofixer). This helps make our tests more comprehensive, especially so that the tests will catch any future autofixer changes.

The documentation for `output` is here: https://eslint.org/docs/developer-guide/nodejs-api#ruletester
@bmish bmish requested a review from Turbo87 February 11, 2019 00:32
@bmish bmish added the Internal label Feb 11, 2019
Turbo87
Turbo87 approved these changes Feb 11, 2019
View reviewed changes
Copy link
Member

@Turbo87 Turbo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea! 👍

@Turbo87 Turbo87 merged commit 4536a17 into ember-cli:master Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Turbo87 Turbo87 Turbo87 approved these changes

Assignees
No one assigned
Labels
Internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bmish @Turbo87