Add new no-unnecessary-service-injection-argument rule
#378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
changed the title
no-unnecessary-service-injection-argument rule
|
I disagree with some of the examples 😺 ^ should absolutely be allowed, it avoids needless runtime camelization <-> dasherization from happening in the resolver and is a good thing. Making the rule focus on single word injections removes this concern... |
|
@rwjblue thanks for the feedback. I have updated the rule to only disallow exact name matches, meaning dasherized names will now be allowed as an argument. Out of curiosity, is the performance hit from camelization <-> dasherization actually meaningful? I assumed it would negligible, and that we should prefer to write the cleanest code instead. |
Turbo87
approved these changes
Mar 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rule documentation.