Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-test-and-then: slight optimization #375

Merged
merged 1 commit into from Jan 16, 2019
Merged

no-test-and-then: slight optimization #375

merged 1 commit into from Jan 16, 2019

Conversation

bmish
Copy link
Member

@bmish bmish commented Jan 15, 2019

The filename only needs to be checked once per file. We don't need to check it while traversing the AST.

@bmish bmish added Bug and removed Bug labels Jan 16, 2019
@bmish bmish changed the title refactor: move filename check up for improved efficiency in 'no-test-and-then' rule. no-test-and-then: slight optimization Jan 16, 2019
@bmish bmish merged commit 0f250b0 into ember-cli:master Jan 16, 2019
@bmish bmish removed the Bug label Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants