Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no-unnecessary-route-path-option: Add support for --fix #373

Merged
merged 1 commit into from Jan 12, 2019
Merged

no-unnecessary-route-path-option: Add support for --fix #373

merged 1 commit into from Jan 12, 2019

Conversation

bmish
Copy link
Member

@bmish bmish commented Jan 11, 2019

No description provided.

Turbo87
Turbo87 approved these changes Jan 12, 2019
View reviewed changes
Copy link
Member

@Turbo87 Turbo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet, thanks @bmish!

I guess the extra space doesn't matter too much as ESLint would probably format that away in the second pass if a corresponding rule is enabled 🤔

@Turbo87 Turbo87 changed the title feat: add autofixer for 'no-unnecessary-route-path-option' rule. no-unnecessary-route-path-option: Add support for --fix Jan 12, 2019
@Turbo87 Turbo87 merged commit 4a624a8 into ember-cli:master Jan 12, 2019
@bmish
Copy link
Member Author

bmish commented Jan 12, 2019

@Turbo87 correct, prettier for example will eliminate the extra spaces left over, which is why I kept the autofixer simple instead of trying to handle all of the whitespace myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Turbo87 Turbo87 Turbo87 approved these changes

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bmish @Turbo87