Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new 'no-unnecessary-route-path-option' rule #370

Merged
merged 1 commit into from Jan 10, 2019
Merged

Add new 'no-unnecessary-route-path-option' rule #370

merged 1 commit into from Jan 10, 2019

Conversation

bmish
Copy link
Member

@bmish bmish commented Jan 6, 2019 •
edited

Turbo87
Turbo87 reviewed Jan 9, 2019
View reviewed changes
Copy link
Member

@Turbo87 Turbo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good already. we might need special handling for index routes though. or maybe we should have a dedicated rule that disallows index route declarations completely? 🤔

@bmish
Copy link
Member Author

bmish commented Jan 10, 2019 •
edited

Good idea. I think that deserves its only rule no-unnecessary-index-route. I can follow up with that additional rule soon: #372

@Turbo87 Turbo87 merged commit 16e0a6f into ember-cli:master Jan 10, 2019
@Turbo87 Turbo87 changed the title feat: add new rule 'no-unnecessary-route-path-option'. Add new 'no-unnecessary-route-path-option' rule Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Turbo87 Turbo87 Turbo87 approved these changes

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bmish @Turbo87