Fix crash from attempting to access non-existent dependent key in no-tracked-property-from-args rule

[joancc]

Fixes #1734

1. Open to initial feedback for a better route if this is not desirable. I can add some checks to the no-tracked-properties rule, but figure the current logic should be supported without failing.

const hasThisArgsValue =
    node.value &&
    startsWithThisExpression(node.value) &&
    nodeToDependentKey(node.value, context).split('.')[0] === 'args';

2. If this path sounds good as a solution, should we be returning the empty string (current) or method name instead?

[bmish]

Let's use undefined to indicate there's no dependent key.

[bmish]

I think my original goal with nodeToDependentKey() was for it to only be called when we knew there would be a dependent key. But since it sounds like it's a hassle for the caller to check for that, your approach of simply bailing out without causing a failure seems reasonable.

[bmish]

Since it sounds like this fixes a bug in a rule, can you update the PR title to mention that?

[joancc]

Thanks for the feedback. Updated to return undefined and added a check on the original rule no-tracked-property-from-args. Wanted to avoid it by returning the empty string, but that's probably misleading.

[bmish]

Having to calculate the dependent key twice isn't ideal. Can't we use optional chaining here?

Suggested change

	nodeToDependentKey(node.value, context) &&
	nodeToDependentKey(node.value, context).split('.')[0] === 'args';
	nodeToDependentKey(node.value, context)?.split('.')[0] === 'args';

[joancc]

Fair point!

[bmish]

Thank you!