Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new rule no-runloop #1703

Merged
merged 4 commits into from Dec 20, 2022
Merged

Add new rule no-runloop #1703

merged 4 commits into from Dec 20, 2022

Conversation

lin-ll
Copy link
Collaborator

@lin-ll lin-ll commented Dec 17, 2022

Fixes #1140

@lin-ll lin-ll self-assigned this Dec 17, 2022
bmish
bmish reviewed Dec 18, 2022
View reviewed changes
lib/rules/no-runloop.js Outdated Show resolved Hide resolved
lib/rules/no-runloop.js Outdated Show resolved Hide resolved
lib/rules/no-runloop.js Outdated Show resolved Hide resolved
tests/lib/rules/no-runloop.js Outdated Show resolved Hide resolved
docs/rules/no-runloop.md Outdated Show resolved Hide resolved
bmish
bmish reviewed Dec 19, 2022
View reviewed changes
docs/rules/no-runloop.md Outdated Show resolved Hide resolved
bmish
bmish reviewed Dec 19, 2022
View reviewed changes
docs/rules/no-runloop.md Outdated Show resolved Hide resolved
bmish
bmish approved these changes Dec 19, 2022
View reviewed changes
Copy link
Member

@bmish bmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Feel free to merge and release it when ready.

@bmish
Copy link
Member

bmish commented Dec 19, 2022

Do you think this should become a recommended rule in a future major version?

@lin-ll @bmish
Apply suggestions from code review
b2c0562 
Co-authored-by: Bryan Mishkin <698306+bmish@users.noreply.github.com>
@lin-ll
Copy link
Collaborator Author

lin-ll commented Dec 19, 2022

Do you think this should become a recommended rule in a future major version?

@bmish yes!

@lin-ll lin-ll merged commit aa397aa into ember-cli:master Dec 20, 2022
@bmish bmish mentioned this pull request Dec 20, 2022
Closed
@bmish
Copy link
Member

bmish commented Dec 20, 2022

@lin-ll would you like to do the release?

@lin-ll
Copy link
Collaborator Author

lin-ll commented Dec 20, 2022

@bmish Hmmm I can try 😂
11.3.0 yeah?

@bmish
Copy link
Member

bmish commented Dec 20, 2022

Yep!

joancc pushed a commit to joancc/eslint-plugin-ember that referenced this pull request Dec 20, 2022
@lin-ll @bmish
Add new rule no-runloop (ember-cli#1703)
ff292af 
* Add new rule

* Address comments

* Apply suggestions from code review

Co-authored-by: Bryan Mishkin <698306+bmish@users.noreply.github.com>

* Fix prefer-rest-params

Co-authored-by: Bryan Mishkin <698306+bmish@users.noreply.github.com>
rtablada pushed a commit to rtablada/eslint-plugin-ember that referenced this pull request Dec 30, 2022
@lin-ll @bmish @rtablada
Add new rule no-runloop (ember-cli#1703)
dd8c3c5 
* Add new rule

* Address comments

* Apply suggestions from code review

Co-authored-by: Bryan Mishkin <698306+bmish@users.noreply.github.com>

* Fix prefer-rest-params

Co-authored-by: Bryan Mishkin <698306+bmish@users.noreply.github.com>
@lin-ll lin-ll deleted the lin-ll/no-runloop branch June 26, 2023 18:02
@bmish bmish mentioned this pull request Oct 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmish bmish bmish approved these changes

Assignees

@lin-ll lin-ll

Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New rule: no-immediate-run
2 participants
@lin-ll @bmish