Support if/else route definitions in no-shadow-route-definition rule
#1297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raido
force-pushed
the
fix-if-else-no-shadow-route
branch
from
89445ba
to
d37ca0e
Compare
|
@bmish 🤞 for a review :) |
raido
commented
Sep 14, 2021
| !isNestedRouteWithSamePath(routeInfo) | ||
| ) { | ||
| const existingRouteInfo = routeMap.get(routeInfo.route.fullPathWithGenericParams); | ||
| const routeLookupKey = `${routeInfo.route.blockStatementsTreePrefix}::${routeInfo.route.fullPathWithGenericParams}`; |
There was a problem hiding this comment.
For routes that are not within if else blocks, key will look like ::<path> - we could set it global::<path> for easier understanding what's the contents of route map. 🤷♂️
bmish
changed the title
no-shadow-route-definition rule
bmish
approved these changes
Sep 19, 2021
|
It sure has grown over time more complex than original implementation. Refactoring it should be done in another PR though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt support if else statements for route definitions.
We are building prefix key from block statements ranges that are within given if statement block and use it for routeMap lookup.
Closes #1268