Fix crash with dynamic/variable route name in no-shadow-route-definition rule

[bmish]

Fixes #1107.

[bmish]

@raido does this fix look good?

[raido]

@bmish 👍

[artursmirnov]

@bmish thank you for fixing the issue so quickly! Although, it fixes the issue only partly. It works perfectly for the cases mentioned in the tests (this.route(someVariable) and this.route('route', { path: someVariable }), but still errors when such route has nested ones, even static. For instance:

this.route(someVariable, function () {
  this.route('route');
});

In this case ESLint breaks with the same error but on the this.route('route'); line – looks like it tries to compose the full route path for it and fails on variable segment higher in the hierarchy.

Could you please take another look at it when you have a chance? Thank you so much in advance!

[bmish]

@artursmirnov thanks for reporting, I reopened the issue.