Add Windows to CI testing matrix #1052
Merged
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The quotes are not needed since it's not being interpreted by the shell https://github.com/igorshubovych/markdownlint-cli#globbing-examples
bmish
reviewed
Dec 23, 2020
| @@ -0,0 +1 @@ | |||
| * text=auto eol=lf | |||
There was a problem hiding this comment.
It checks out the code with LF line endings on Windows instead of the default CRLF. The CRLF line endings seemed to cause some issues when running Prettier on CI.
bmish
approved these changes
Dec 23, 2020
|
Thanks! |
This was referenced Mar 11, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run the tests on Windows. There should be some test failures which are fixed in #1051