Deprecate trivial node type check helpers #1720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmish
changed the title
This was referenced Dec 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has come up a bunch recently and been an issue I have wanted to solve for a long time.
Trivial helpers in this file that only check a node's existence and/or type are deprecated in favor of inlining that check. We don't need a function for every type of node. We should inline these trivial checks and only check for node existence when it's actually a possibility a node might not exist.
And as written, these functions won't correctly narrow the type of the node, which we would need if we incorporate TypeScript: #1613
Removing these trivial functions would also help prepare for future TypeScript incorporation: