Merge pull request #919 from bmish/route-path-style-fix-variable-path

Fix crash with variable path in `route-path-style` rule
ember-cli · Aug 18, 2020 · d9107e1 · d9107e1
2 parents 384ccdd + 400eb53
commit d9107e1
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/lib/rules/route-path-style.js b/lib/rules/route-path-style.js
@@ -44,9 +44,12 @@ module.exports = {
         const pathValueNode = hasExplicitPathOption
           ? getPropertyByKeyName(node.arguments[1], 'path').value
           : node.arguments[0];
-        const pathValue = pathValueNode.value;
 
-        const urlSegments = getStaticURLSegments(pathValue);
+        if (!types.isStringLiteral(pathValueNode)) {
+          return;
+        }
+
+        const urlSegments = getStaticURLSegments(pathValueNode.value);
 
         if (urlSegments.some((urlPart) => !isKebabCase(urlPart))) {
           context.report(pathValueNode, ERROR_MESSAGE);

diff --git a/tests/lib/rules/route-path-style.js b/tests/lib/rules/route-path-style.js
@@ -11,7 +11,12 @@ const { ERROR_MESSAGE } = rule;
 // Tests
 //------------------------------------------------------------------------------
 
-const ruleTester = new RuleTester();
+const ruleTester = new RuleTester({
+  parserOptions: {
+    ecmaVersion: 6,
+    sourceType: 'module',
+  },
+});
 ruleTester.run('route-path-style', rule, {
   valid: [
     // Implicit path:
@@ -78,6 +83,10 @@ ruleTester.run('route-path-style', rule, {
 
     // Incorrect usage:
     'this.route();',
+
+    // With variable:
+    "this.route('team', { path: myPath });",
+    "this.route('team', { path: `part-${some-variable}` });", // eslint-disable-line no-template-curly-in-string
   ],
   invalid: [
     {