Merge pull request #923 from bmish/no-actions-hash-test-spread

Fix crash with spread syntax in `no-actions-hash` rule
ember-cli · Aug 27, 2020 · 8be94f9 · 8be94f9
2 parents a66a983 + 9b88fa8
commit 8be94f9
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/lib/utils/ember.js b/lib/utils/ember.js
@@ -406,7 +406,11 @@ function isRouteLifecycleHook(property) {
 }
 
 function isActionsProp(property) {
-  return property.key.name === 'actions' && types.isObjectExpression(property.value);
+  return (
+    types.isIdentifier(property.key) &&
+    property.key.name === 'actions' &&
+    types.isObjectExpression(property.value)
+  );
 }
 
 function isComponentLifecycleHookName(name) {

diff --git a/tests/lib/rules/no-actions-hash.js b/tests/lib/rules/no-actions-hash.js
@@ -64,6 +64,11 @@ ruleTester.run('no-actions-hash', rule, {
         },
       });
     `,
+
+    // Spread syntax
+    'Route.extend({ ...foo });',
+    'Route.extend(Evented, { ...foo });',
+    'Route.extend(...foo);',
   ],
 
   invalid: [