Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with ember-source@4.0.0-beta.1+ #697

Merged
merged 5 commits into from
Sep 9, 2021

Conversation

stefanpenner
Copy link
Contributor

@stefanpenner stefanpenner commented Sep 9, 2021

failures:

for ember-beta & ember-canary

  • namespace is missing on the ContainerDebugAdapter (needs debugging)
not ok 2 Chrome 92.0 - [2 ms] - Container Debug Adapter Tests: the default ContainerDebugAdapter catalogs controller entries
    ---
        actual: >
            null
        stack: >
            TypeError: Cannot read property 'modulePrefix' of undefined
                at Class.catalogEntriesByType (http://localhost:7357/assets/vendor.js:67503:35)
                at Object.<anonymous> (http://localhost:7357/assets/tests.js:88:45)
  • ember polyfils has removed merge
not ok 9 Chrome 92.0 - [0 ms] - ember-resolver/resolvers/classic: can lookup something in another namespace
   ---
       actual: >
           null
       stack: >
           TypeError: (0 , _polyfills.merge) is not a function
               at Object.beforeEach (http://localhost:7357/assets/tests.js:153:54)
       message: >
           beforeEach failed on can lookup something in another namespace: (0 , _polyfills.merge) is not a function
       negative: >
           false
       browser log: |
       
  • deprecate is missing a for identifier

@stefanpenner stefanpenner force-pushed the enable-remaining-scenarios branch 2 times, most recently from dabf9a1 to 4b55a79 Compare September 9, 2021 03:22
@stefanpenner
Copy link
Contributor Author

I'm going to split out the embroider failures, so we can land this and then I will focus on those.

@stefanpenner stefanpenner merged commit ec41971 into master Sep 9, 2021
@delete-merged-branch delete-merged-branch bot deleted the enable-remaining-scenarios branch September 9, 2021 16:46
@rwjblue rwjblue changed the title enable currently remaining ember-try scenarios Fix issues with ember-source@4.0.0-beta.1+ Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant