failing test for looking up in namespace contains a @ sign in module prefix #511
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This previously failing test case is for addressing an issue that discussed in discord:
https://discordapp.com/channels/480462759797063690/491905849405472769/682777856446824466
which in short, it is impossible for now to invoke a component from a namespace contains a
@
sign in itsmodulePrefix
.For example, I have an ember add-on that will be published as
@org/ui-kit
. For naming consistency purposes, I set itsmodulePrefix
to"@org/ui-kit"
as well.However, I can not invoke components in this add-on from any consuming application in this form:
<@org/UiKit@Forms::Input />
Although this PR revealed this issue, I still in doubt personally that this form of invocation is a good idea. People can change the
modulePrefix
easily to:<OrgUiKit@Forms::Input />
or re-export it as normal ember add-ons did.