Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for nested colocated components. #417

Merged
merged 3 commits into from Sep 24, 2019

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Sep 24, 2019

This is a more targetted implementation that aims to avoid the breaking change nature of #414 (and #398 before it).

Closes #414

rwjblue and others added 2 commits September 23, 2019 22:31
Chrome doesn't work on trusty anymore.

See travis-ci/docs-travis-ci-com#2513

(cherry picked from commit f57cba1)
@rwjblue
Copy link
Member Author

rwjblue commented Sep 24, 2019

Currently failing due to the issue reported in socketio/engine.io#589. Will attempt to pin engine.io to the prior release.

@rwjblue
Copy link
Member Author

rwjblue commented Sep 24, 2019

Tested in the octane blueprint as well:

❯ ember g component foo --component-structure=nested
installing component
  create app/components/foo/index.hbs
  skip app/components/foo/index.js
  tip to add a class, run `ember generate component-class foo`
installing component-test
  create tests/integration/components/foo-test.js

~/sandbox/octane-app-20190923 master*
❯ ember test
Could not start watchman
Visit https://ember-cli.com/user-guide/#watchman for more info.
Environment: test
cleaning up...
Built project successfully. Stored in "/var/folders/mt/yt2qjpl93ls98lrkrs81rzch000pzv/T/tests-dist-2019823-38750-2drncw.6nefj".
ok 1 Chrome 77.0 - [401 ms] - Integration | Component | foo: it renders
ok 2 Chrome 77.0 - [1 ms] - ember-qunit: Ember.onerror validation: Ember.onerror is functioning properly

1..2
# tests 2
# pass  2
# skip  0
# fail  0

# ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants