Fix MU GlimmerResolver.normalize
when fullName
is not present
#338
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error is triggered when injecting an MU addon service like:
The change checks that
fullName
is not empty to avoid triggering the error. The error is triggered when the registry callsnormalize
at https://github.com/emberjs/ember.js/blob/master/packages/%40ember/-internals/container/lib/registry.ts#L690:In this case,
options.source
will be null, butoptions.namespace
ismy-addon
.This fix makes that the service can be resolved correctly.
I also wonder if the current implementation of the MU
Glimmer.resolve
may not cover all the possible cases, because the GlobalsResolver.resolve and ClassicResolver.resolve look different. (Note: I am not familiar with this code).cc @rwjblue